web-api: basic module system integration tests, removing unused bits, dependency updates #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmaj
added
semver:major
enhancement
…or them, updated Busboy usage in tests to latest documented API.
zimeg
approved these changes
Jan 16, 2024
| process.exit(1); | ||
| } catch (e) { | ||
| assert(e.message.includes('invalid_auth'), '❌ Did not receive expected "invalid_auth" response from `auth.test` API, ESM project integration test failed.'); | ||
| console.log('✅ ESM project integration test succeeded!'); |
There was a problem hiding this comment.
| }, | ||
| "extends": "@tsconfig/recommended/tsconfig.json", |
| "typescript": "^4.1" | ||
| "ts-node": "^10", | ||
| "tsd": "^0.30.0", | ||
| "typescript": "5.3.3" |
There was a problem hiding this comment.
🔒🔒🔒🔒🔒.3.3 👍 Happy to remove breaking builds from this!
There was a problem hiding this comment.
Farewell, deno-shims/buffer-shim.js 👋 😔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1679 .
In prep for web-api v7 release, doing some cleanup and dependency updates, specifically:
test/integration: one for a CommonJS-based project and one for an ESM-based project, ensuring that no matter which module system is used, web-api is compatible with it. By changing thetypefield withinpackage.jsonand/or modifying thetsconfig.jsoncompilerOptions, the code emitted for distribution may or may not be compatible with each style of project. These integration tests ensure compatibility with both.typescriptdependency to the latest version. Locking to a specific version as typescript notoriously introduces breaking changes in minor and patch releases.tsconfig.jsonand re-using the 'recommended' tsconfig base as much as possible.capture-consoledev dependency, can use sinon for the same functionality.